Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.schema.json titles #299

Closed
timoline opened this issue Feb 7, 2021 · 8 comments
Closed

settings.schema.json titles #299

timoline opened this issue Feb 7, 2021 · 8 comments

Comments

@timoline
Copy link
Contributor

timoline commented Feb 7, 2021

Can we / I just change some titles in the schema, without breaking anything?

like:
Advanced settings -> Advanced
Experimental options -> Experimental
Networkmap options -> Networkmap
MQTT settings -> MQTT
Serial settings -> Serial

Because we already in Settings I think its not needed.... :-)

@nurikk
Copy link
Owner

nurikk commented Feb 7, 2021

Sure you can, just raise PR

@timoline
Copy link
Contributor Author

timoline commented Feb 7, 2021

Is it also possible to do a little reorganize in the settings?
I mean, advanced is pretty large, maybe we can move the logging options to its own menu-item?

And I also see a baudrate setting which should be moved to serial

@nurikk
Copy link
Owner

nurikk commented Feb 7, 2021

yes, you can do this in this file
https://github.com/nurikk/z2m-frontend/blob/master/src/components/settings/uiSchema.json

raise the PR and don't forget to attach screenshot with resulting changes

@timoline
Copy link
Contributor Author

timoline commented Feb 7, 2021

I'm not sure how to do this, is possible for you to create a little example?
(for example the logging options)

@timoline
Copy link
Contributor Author

timoline commented Feb 7, 2021

I just noticed that the description for a boolean is not working yet

image

@nurikk
Copy link
Owner

nurikk commented Feb 7, 2021

I just noticed that the description for a boolean is not working yet

image

yep, known issue rjsf-team/react-jsonschema-form#2203

@timoline
Copy link
Contributor Author

timoline commented Feb 8, 2021

I wanted to change the networkmap (colors) with "format": "color"

In the playground it works fine
https://rjsf-team.github.io/react-jsonschema-form/

But when I add this to the settings.schema.json it just won't work, do you have any idea?

@nurikk
Copy link
Owner

nurikk commented Feb 9, 2021

I wanted to change the networkmap (colors) with "format": "color"

In the playground it works fine
https://rjsf-team.github.io/react-jsonschema-form/

But when I add this to the settings.schema.json it just won't work, do you have any idea?

No need to tinker with this options, they are from internal z2m map implementation. I’ll hide this options from UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants