-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Article lists are incredibly laggy on mobile Firefox and overall theme performance is very low #994
Comments
Importantly, this issue does not appear to be present in the upstream Congo. |
Seems fine on Linux using the version 118.0.2 (64-bit). Maybe it's an extension you have installed, try opening the page on a private tab. |
I'll edit the issue title back to the original -- this is predominantly a mobile effect |
Here, the Blowfish documentation achieves 56/100 on mobile PageSpeed Insights whereas most popular Hugo themes achieve at or near 100%. |
Actually, even the "Welcome to Blowfish" article hits 35% on mobile and 72% on desktop, so this is likely a device agnostic problem. |
A related issue previously observed is use of |
Any suggestions on what needs to be done? |
You'd probably have to profile the code to see which bits are excessively slow, but the |
@ragibson For setups with Views/Likes that makes some sense - a list page triggers a "couple" requests to the DB. Need further investigation. Would you be able to help translate this into a set of actions that we need to fix? |
Indeed, I have this kind of problem too. Page scrolling is stuck, but when used on Firefox browser, it is better than edge browser. inPrivate mode is still stuck. |
It's almost certainly not a network/DB bottleneck since it's tied to scrolling for the entire lifetime of the page. On a very cursory profile from my phone it seems that Blowfish pages are ~5x more intensive on the renderer than a similar one in Congo for some reason. |
I think it's due to an overzealous use of For example, https://blowfish.page/ requires 200-300 times as many draw calls on every frame of a scroll than other comparable sites. For now, I've completely disabled those CSS classes on everything except the search widget and the scrolling issues are improved tremendously with effectively zero stutter. |
I think I've fixed the issue in the PR above for the case where the blur features are disabled. It has the same ~200x reduction in draw calls on Firefox in that case. Otherwise, I found a lot of documentation stating that these blur filters are inherently intensive and should be avoided, especially on mobile devices. Even after the PR, Blowfish uses them very frequently (and on multiple elements) whenever |
Use webp images and add Observe the difference |
@demodeveloperlab we already established this is unrelated to any network overhead or asset loading and is/was predominantly due to rendering overhead from extraneous CSS rules, but thanks for the suggestion |
added @demodeveloperlab suggestion in a commit for something else and @ragibson already provided a bunch of improvements for this closing the issue |
Describe the bug
Scrolling through a list of articles is very laggy and jagged on Firefox. Overall performance of the theme is also slow.
To Reproduce
This appears to occur on pretty much every Blowfish website, including https://blowfish.page/docs/.
EDIT: For example,
Expected behavior
The page scrolls smoothly and overall performance is improved.
Screenshots
N/A
Desktop (please complete the following information):
Hugo & Blowfish versions
The scrolling issue is on most sites I have checked and the issue has persisted for months, so it should affect all recent versions.
Additional context
N/A
The text was updated successfully, but these errors were encountered: