Invalid characters in test name breaks test runner

[laura-campbell]

• versions: NUnit 3.0 and NUnit Adapter 3.10.0.21

• Visual Studio Professional version 15.8.5

• .NET framework is 4.6.1

• When a test with a custom name has invalid characters in that name (in this case, '&'), the nunit adapter throws an error and the tests are removed from the window

• Only appears to happen when you select a group of tests

• Doesn't appear to happen on other machines

• repro: https://github.com/laura-campbell/nunit3bug

public class Class1
{
        [TestCaseSource("testcases")]
        public void foo()
        {
        }
        public static IEnumerable<TestCaseData> testcases { get; } = new[] { new TestCaseData().SetName("&") };
}

test is visible after building the solution

chose to run selected tests on a group of tests

test is not run and disappears from the window

Error message:

[9/27/2018 11:47:55 AM Error] An exception occurred while invoking executor 'executor://nunit3testexecutor/': Incorrect format for TestCaseFilter Error: Missing operand. Specify the correct format and try again. Note that the incorrect format can lead to no test getting executed.

[rprouse]

Thanks, looks like a problem parsing the filters that are sent from the test window to the adapter. Does it happen if the test name is more than just &, for exampe apples&pears?

[benjamin-hodgson]

Does it happen if the test name is more than just &, for exampe apples&pears?

Yes it does. (We first encountered it in a test whose name contained a URL with a query string.) The error message is different but I'm confident that it's the same bug.

[rprouse]

Excellent, thanks. That will increase the priority then, especially since & is used in URI query params as you mentioned.

[aboldock]

we are also seeing this problem with 3.10.0.21 with # in the test name and the tests being source from a paramaterised set eg: [Test, TestCaseSource(typeof(AdtPatientTestDataFactory), "TestCases")]
strange thing is not all our devs are seeing the problemonly some, we have changed all our test names to get around this issue on some machines.

[LangdalP]

I am having the same type of problems. I am from Norway, and in our project we use Norwegian test names. This means that the names may contain æøå and ÆØÅ, which breaks the adapter. We have over a thousand tests, and I don't want to start renaming all of them because of this, so currently I am using the console test runner instead.

Edit: I might have been wrong about æøå breaking the test runner. It was more likely some special characters in the test input data (an "&" for instance).

[Macht59]

I have the same problem - just me and non of my colleges.
In my case the error caused by character '='. Replacing '=' characted with 'equals to' resolved the problem.

[johnmwright]

This issue has the same underlying cause as #622 and is resolved by PR #668

[OsirisTerje]

@laura-campbell @Macht59 @benjamin-hodgson @LangdalP @aboldock
Checking 3.16.0-dev on this one. To make it work, NUnit also has to be on Version 3.12.
https://www.myget.org/feed/nunit/package/nuget/NUnit3TestAdapter/3.16.0-dev-01202

Before:

After only adapter upgrade:

After adapter AND NUnit upgrade:

All tested with VS 2019 , 16.3.4