Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result URL in the network app history should be the URL of Capture asset page #2176

Closed
sync-by-unito bot opened this issue Oct 9, 2022 · 10 comments
Closed

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 9, 2022

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Tammy Yang, it's really short description, can I get bit more explanation pls

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Tammy Yang, can you please look at this claap ( https://app.claap.io/numbers-protocol/devs-2-in-1-task-c-O35CsUM4Uy-T3nSPX6u-Z1V )?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Tammy Yang commented:

Done, see my comment in another task.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam
capture asset page url is the following:

https://captureappiframe.numbersprotocol.io/ ( https://captureappiframe.numbersprotocol.io/ )asset_page?nid=

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam let me know if you need anything else or if my understanding is incorrect.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Sam commented:

Ethan Wu, okay so I just need to change Result URL to https://captureappiframe.numbersprotocol.io/ ( https://captureappiframe.numbersprotocol.io/ )asset_page?nid= one right?

Should I put same url in this task ( https://app.asana.com/0/1201016280880500/1202494282094194/f ) then?

seems like these 2 tasks are related.

I recorded claap before maybe claap ( https://app.claap.io/numbers-protocol/devs-2-in-1-task-c-O35CsUM4Uy-T3nSPX6u-Z1V ) can explain better. (In claap Result url is wrong but I will change to one you mentioned)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam let me see. one sec

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam pls stick with the nse asset profile link

bc the flow of social sharing is the following:

  1. navigate users to nse asset profile.
  2. click "collect" will open checkout page in captureiframe.

so the link we want to share with users is the nse asset profile link

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam keep what you have in the claap

@sync-by-unito sync-by-unito bot closed this as completed Nov 1, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Sam commented:

Here is the PR ( #2249 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants