Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional sources for the theme color #77

Closed
freaktechnik opened this issue Apr 12, 2018 · 2 comments
Closed

Support additional sources for the theme color #77

freaktechnik opened this issue Apr 12, 2018 · 2 comments
Milestone

Comments

@freaktechnik
Copy link

freaktechnik commented Apr 12, 2018

Vivaldi Fox currently only uses the theme-color meta tag. However some sites only specify the color in their web app manifest (as theme_color, or sometimes background_color may apply too).

Other potential sources include the status bar being set to black for iOS apps or the windows tile color.

I made a quick proof-of-concept to see what those sources would look like at https://github.com/freaktechnik/website-color/blob/master/content.js

I don't think the windows tile color is a good fit, since most websites that define it don't use a color matching their page, but one complementing their icon (see for example imgur).

@nt1m
Copy link
Owner

nt1m commented Apr 12, 2018

@freaktechnik Great idea! Thanks for finding all these sources! I used to support msApplication-tile in the SDK version, but it didn't give nice results as you said.

Would you like to make a PR ? All the magic happens in these files:

https://github.com/nt1m/vivaldi-fox/blob/master/background/color-utils.js#L103
https://github.com/nt1m/vivaldi-fox/blob/master/data/contentscript.js

@nt1m nt1m added this to the v3 milestone Apr 12, 2018
@nt1m nt1m closed this as completed in 61d79d2 May 31, 2018
@nt1m
Copy link
Owner

nt1m commented Jun 3, 2018

I've added this in the latest beta version: https://github.com/nt1m/vivaldi-fox/releases/tag/v3.0b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants