diff --git a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs index 315b1e5f..fcaddb5c 100644 --- a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs @@ -41,6 +41,14 @@ public void Test() public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"using System; using NSubstitute; using NSubstitute.ExceptionExtensions; diff --git a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs index 018b8112..57d3850f 100644 --- a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs @@ -41,6 +41,14 @@ public void Test() public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"using System; using NSubstitute; using NSubstitute.ExceptionExtensions; diff --git a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs index 54b9a02f..8d708596 100644 --- a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs @@ -46,6 +46,14 @@ public void Test() public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"using System; using NSubstitute; using NSubstitute.ExceptionExtensions; diff --git a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs index 9e274f86..459c27b0 100644 --- a/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.CSharp/DiagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs @@ -45,6 +45,14 @@ public void Test() public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"using System; using NSubstitute; using NSubstitute.ExceptionExtensions; diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs index 2e0c3f8d..eb6ae576 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs @@ -4,6 +4,7 @@ using NSubstitute.Analyzers.Shared.Settings; using NSubstitute.Analyzers.Tests.Shared.Extensibility; using NSubstitute.Analyzers.Tests.Shared.Extensions; +using Xunit; namespace NSubstitute.Analyzers.Tests.VisualBasic.DiagnosticAnalyzersTests.NonSubstitutableMemberAnalyzerTests; @@ -39,6 +40,14 @@ End Namespace public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"Imports System Imports NSubstitute Imports NSubstitute.ExceptionExtensions diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs index c3ec97d3..8b37df7c 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs @@ -44,6 +44,14 @@ End Namespace public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"Imports System Imports NSubstitute Imports NSubstitute.ExceptionExtensions diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs index f4f86020..9b8a82a8 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs @@ -43,6 +43,14 @@ End Namespace public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type) { + if (method.Contains("Async")) + { + // ThrowsAsync like methods do not extend literals + // TODO replace with Assert.Skip once xUnit v3 released + // https://github.com/xunit/xunit/issues/2073 + return; + } + var source = $@"Imports System Imports NSubstitute Imports NSubstitute.ExceptionExtensions