From 548872bb3ca36a0030dec3e459a7a286d5937ea5 Mon Sep 17 00:00:00 2001 From: tpodolak Date: Sun, 2 Oct 2022 21:15:11 +0200 Subject: [PATCH] GH-153 - adding missing sealed modifiers --- .../AbstractConstructorArgumentsForInterfaceCodeFixProvider.cs | 2 +- .../AbstractInternalSetupSpecificationCodeFixProvider.cs | 2 +- ...actPartialSubstituteUsedForUnsupportedTypeCodeFixProvider.cs | 2 +- .../AbstractReceivedInReceivedInOrderCodeFixProvider.cs | 2 +- .../AbstractSubstituteForInternalMemberCodeFixProvider.cs | 2 +- .../AbstractSyncOverAsyncThrowsCodeFixProvider.cs | 2 +- .../DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs | 2 +- .../AbstractConflictingArgumentAssignmentsAnalyzer.cs | 2 +- .../AbstractNonSubstitutableMemberArgumentMatcherAnalyzer.cs | 2 +- .../AbstractNonSubstitutableMemberReceivedAnalyzer.cs | 2 +- .../AbstractNonSubstitutableMemberWhenAnalyzer.cs | 2 +- .../DiagnosticAnalyzers/AbstractReEntrantSetupAnalyzer.cs | 2 +- .../AbstractReceivedInReceivedInOrderAnalyzer.cs | 2 +- .../DiagnosticAnalyzers/AbstractSubstituteAnalyzer.cs | 2 +- .../DiagnosticAnalyzers/AbstractSyncOverAsyncThrowsAnalyzer.cs | 2 +- .../DiagnosticAnalyzers/AbstractUnusedReceivedAnalyzer.cs | 2 +- .../AbstractWithAnyArgsArgumentMatcherAnalyzer.cs | 2 +- 17 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractConstructorArgumentsForInterfaceCodeFixProvider.cs b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractConstructorArgumentsForInterfaceCodeFixProvider.cs index ca16fdbc..f47c36a1 100644 --- a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractConstructorArgumentsForInterfaceCodeFixProvider.cs +++ b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractConstructorArgumentsForInterfaceCodeFixProvider.cs @@ -18,7 +18,7 @@ internal abstract class AbstractConstructorArgumentsForInterfaceCodeFixProvider public override ImmutableArray FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticIdentifiers.SubstituteConstructorArgumentsForInterface); - public override Task RegisterCodeFixesAsync(CodeFixContext context) + public sealed override Task RegisterCodeFixesAsync(CodeFixContext context) { var codeAction = CodeAction.Create( "Remove constructor arguments", diff --git a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractInternalSetupSpecificationCodeFixProvider.cs b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractInternalSetupSpecificationCodeFixProvider.cs index b9e8a90c..37de3e43 100644 --- a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractInternalSetupSpecificationCodeFixProvider.cs +++ b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractInternalSetupSpecificationCodeFixProvider.cs @@ -15,7 +15,7 @@ internal abstract class AbstractInternalSetupSpecificationCodeFixProvider FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticIdentifiers.PartialSubstituteForUnsupportedType); - public override async Task RegisterCodeFixesAsync(CodeFixContext context) + public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) { var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false); var syntaxNode = root.FindNode(context.Span, getInnermostNodeForTie: true); diff --git a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractReceivedInReceivedInOrderCodeFixProvider.cs b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractReceivedInReceivedInOrderCodeFixProvider.cs index d79ce447..e3d9e8c4 100644 --- a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractReceivedInReceivedInOrderCodeFixProvider.cs +++ b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractReceivedInReceivedInOrderCodeFixProvider.cs @@ -16,7 +16,7 @@ internal abstract class AbstractReceivedInReceivedInOrderCodeFixProvider : CodeF public override ImmutableArray FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticIdentifiers.ReceivedUsedInReceivedInOrder); - public override Task RegisterCodeFixesAsync(CodeFixContext context) + public sealed override Task RegisterCodeFixesAsync(CodeFixContext context) { var codeAction = CodeAction.Create( "Remove redundant Received checks", diff --git a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSubstituteForInternalMemberCodeFixProvider.cs b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSubstituteForInternalMemberCodeFixProvider.cs index 7b127dbc..f7682106 100644 --- a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSubstituteForInternalMemberCodeFixProvider.cs +++ b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSubstituteForInternalMemberCodeFixProvider.cs @@ -19,7 +19,7 @@ protected AbstractSubstituteForInternalMemberCodeFixProvider(ISubstituteProxyAna _substituteProxyAnalysis = substituteProxyAnalysis; } - public override async Task RegisterCodeFixesAsync(CodeFixContext context) + public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) { var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false); diff --git a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSyncOverAsyncThrowsCodeFixProvider.cs b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSyncOverAsyncThrowsCodeFixProvider.cs index fd73d813..9bb9ce7c 100644 --- a/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSyncOverAsyncThrowsCodeFixProvider.cs +++ b/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractSyncOverAsyncThrowsCodeFixProvider.cs @@ -26,7 +26,7 @@ protected AbstractSyncOverAsyncThrowsCodeFixProvider(ISubstitutionNodeFinder sub public override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer; - public override async Task RegisterCodeFixesAsync(CodeFixContext context) + public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) { var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false); diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs index cd004523..1193bc2f 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs @@ -36,7 +36,7 @@ protected AbstractCallInfoAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs index 5ce84e7d..9d9b3ff6 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs @@ -26,7 +26,7 @@ protected AbstractConflictingArgumentAssignmentsAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberArgumentMatcherAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberArgumentMatcherAnalyzer.cs index 07651474..3071b565 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberArgumentMatcherAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberArgumentMatcherAnalyzer.cs @@ -41,7 +41,7 @@ protected AbstractNonSubstitutableMemberArgumentMatcherAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberReceivedAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberReceivedAnalyzer.cs index 91c74dd7..85baeab5 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberReceivedAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberReceivedAnalyzer.cs @@ -27,7 +27,7 @@ protected AbstractNonSubstitutableMemberReceivedAnalyzer( protected override DiagnosticDescriptor NonVirtualSetupDescriptor { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationOperation, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberWhenAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberWhenAnalyzer.cs index 2d68ee7b..75fe9394 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberWhenAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractNonSubstitutableMemberWhenAnalyzer.cs @@ -31,7 +31,7 @@ protected AbstractNonSubstitutableMemberWhenAnalyzer( protected override DiagnosticDescriptor NonVirtualSetupDescriptor { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReEntrantSetupAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReEntrantSetupAnalyzer.cs index 6b00ee9d..5f57a5fb 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReEntrantSetupAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReEntrantSetupAnalyzer.cs @@ -25,7 +25,7 @@ protected AbstractReEntrantSetupAnalyzer( SupportedDiagnostics = ImmutableArray.Create(DiagnosticDescriptorsProvider.ReEntrantSubstituteCall); } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReceivedInReceivedInOrderAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReceivedInReceivedInOrderAnalyzer.cs index 0bc241fe..2e9c3097 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReceivedInReceivedInOrderAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractReceivedInReceivedInOrderAnalyzer.cs @@ -25,7 +25,7 @@ protected AbstractReceivedInReceivedInOrderAnalyzer( SupportedDiagnostics = ImmutableArray.Create(diagnosticDescriptorsProvider.ReceivedUsedInReceivedInOrder); } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstituteAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstituteAnalyzer.cs index b3a78376..5b4e6a5f 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstituteAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstituteAnalyzer.cs @@ -44,7 +44,7 @@ protected AbstractSubstituteAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSyncOverAsyncThrowsAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSyncOverAsyncThrowsAnalyzer.cs index 1fc0b2dd..c3501f13 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSyncOverAsyncThrowsAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSyncOverAsyncThrowsAnalyzer.cs @@ -24,7 +24,7 @@ protected AbstractSyncOverAsyncThrowsAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractUnusedReceivedAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractUnusedReceivedAnalyzer.cs index 9009c519..4629d9b0 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractUnusedReceivedAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractUnusedReceivedAnalyzer.cs @@ -23,7 +23,7 @@ protected AbstractUnusedReceivedAnalyzer(IDiagnosticDescriptorsProvider diagnost private static readonly ImmutableHashSet PossibleParents = ImmutableHashSet.Create(OperationKind.PropertyReference, OperationKind.Invocation); - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); } diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractWithAnyArgsArgumentMatcherAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractWithAnyArgsArgumentMatcherAnalyzer.cs index 45bfdb5b..eb0c472d 100644 --- a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractWithAnyArgsArgumentMatcherAnalyzer.cs +++ b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractWithAnyArgsArgumentMatcherAnalyzer.cs @@ -29,7 +29,7 @@ protected AbstractWithAnyArgsArgumentMatcherAnalyzer( public override ImmutableArray SupportedDiagnostics { get; } - protected override void InitializeAnalyzer(AnalysisContext context) + protected sealed override void InitializeAnalyzer(AnalysisContext context) { context.RegisterOperationAction(_analyzeInvocationAction, OperationKind.Invocation); }