Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Generating pipe or directive #110

Closed
devahmedsaleh opened this issue Mar 20, 2019 · 1 comment
Closed

Bug: Generating pipe or directive #110

devahmedsaleh opened this issue Mar 20, 2019 · 1 comment

Comments

@devahmedsaleh
Copy link

I still have an issue while generating pipe or directive, this may be related to #68 but not resolved in my case.

example: generate pipe to the default feature (UI)

ng generate @nstudio/schematics:pipe size

CREATE libs/features/ui/pipes/size.pipe.ts (183 bytes)
UPDATE libs/features/ui/pipes/index.ts (476 bytes)
UPDATE libs/features/ui/ui.module.ts (362 bytes)

libs/features/ui/pipes/index.js this exports a PIPES array.

export const PIPES = [
  DateOrderPipe,
  SizePipe
];

libs/features/ui/ui.module.ts imports and uses UI_PIPES array which is not found (not exported)
import { UI_PIPES } from './pipes';
exports: [...MODULES, ...PIPES, ...UI_PIPES]

The same thing applied with directives

@NathanWalker
Copy link
Member

Thanks for heads up - this is fixed in 7.4.4 now 👍 (if generated in workspace already can just update or remove the ...PIPES one)...should be UI_PIPES in this case. 7.4.4 will make sure of that for new workspaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants