fix(generators): install dependencies for app.nativescript (#107)

close #106
nstudio · Mar 18, 2019 · d59d94a · d59d94a
1 parent 1b0618f
commit d59d94a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/app.nativescript/index.ts b/src/app.nativescript/index.ts
@@ -13,7 +13,7 @@ import {
   schematic,
   noop,
 } from '@angular-devkit/schematics';
-import { stringUtils, prerun, getNpmScope, getPrefix, addRootDeps, updatePackageScripts, updateAngularProjects, updateNxProjects, applyAppNamingConvention, getGroupByName, getAppName, missingArgument, getJsonFromFile, setDependency, updateJsonFile } from '../utils';
+import { stringUtils, prerun, getNpmScope, getPrefix, addRootDeps, updatePackageScripts, updateAngularProjects, updateNxProjects, applyAppNamingConvention, getGroupByName, getAppName, missingArgument, addInstall, getJsonFromFile, setDependency, updateJsonFile } from '../utils';
 import { Schema as ApplicationOptions } from './schema';
 
 export default function (options: ApplicationOptions) {
@@ -43,6 +43,7 @@ export default function (options: ApplicationOptions) {
       })(tree, context),
     // add root package dependencies
     (tree: Tree) => addRootDeps(tree, {nativescript: true}),
+    addInstall,
     addNsCli(options.addCliDependency),
     // add start/clean scripts
     (tree: Tree) => {

diff --git a/src/app.nest/index.ts b/src/app.nest/index.ts
@@ -14,7 +14,6 @@ import {
   noop,
   externalSchematic
 } from "@angular-devkit/schematics";
-import { NodePackageInstallTask } from "@angular-devkit/schematics/tasks";
 import {
   stringUtils,
   getNpmScope,
@@ -29,7 +28,8 @@ import {
   applyAppNamingConvention,
   getAppName,
   updateJsonInTree,
-  missingArgument
+  missingArgument,
+  addInstall
 } from "../utils";
 
 export default function (options: ApplicationOptions) {
@@ -101,11 +101,6 @@ export default function (options: ApplicationOptions) {
   ]);
 }
 
-function addInstall(host: Tree, context: SchematicContext) {
-  context.addTask(new NodePackageInstallTask());
-  return host;
-}
-
 function addAppFiles(
   options: ApplicationOptions,
   appPath: string,

diff --git a/src/utils/general.ts b/src/utils/general.ts
@@ -23,6 +23,7 @@ import { toFileName } from "./name-utils";
 const util = require('util');
 const xml2js = require('xml2js');
 import * as stripJsonComments from 'strip-json-comments';
+import { NodePackageInstallTask } from "@angular-devkit/schematics/tasks";
 
 export const supportedPlatforms = [
   "web",
@@ -1315,3 +1316,8 @@ export const toComponentClassName = (name: string) =>
   `${classify(name)}Component`;
 
 export const toNgModuleClassName = (name: string) => `${classify(name)}Module`;
+
+export function addInstall(host: Tree, context: SchematicContext) {
+  context.addTask(new NodePackageInstallTask());
+  return host;
+}