Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for searchv2 #953

Merged
merged 1 commit into from
Feb 25, 2025
Merged

tests: add tests for searchv2 #953

merged 1 commit into from
Feb 25, 2025

Conversation

evgeniiz321
Copy link
Contributor

closes #951

@evgeniiz321 evgeniiz321 force-pushed the ezayats/searchv2 branch 3 times, most recently from f4686f0 to 43a02ed Compare February 20, 2025 01:48
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREFIX == "" is an interesting case for us to test as well.

Mixed numeric/non-numeric contents in attributes (attr=X and attr=10 in different objects).

Order of unfiltered search (which is effectively listing everything) is by OID.

@evgeniiz321
Copy link
Contributor Author

evgeniiz321 commented Feb 20, 2025

Can't verify the case with COMMON_PREFIX == "", since CLI doesn't allow to specify empty strings. Not sure if this is by design or not.

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Feb 21, 2025

Can't verify the case with COMMON_PREFIX == "", since CLI doesn't allow to specify empty strings. Not sure if this is by design or not.

$ neofs-cli object searchv2 -h
  -f, --filters strings       Repeated filter expressions or files with protobuf JSON

JSON may help u for now. Btw if is declared, then each test should be run in both formats

@evgeniiz321
Copy link
Contributor Author

Added test cases with empty prefix.

closes #951

Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
@evgeniiz321
Copy link
Contributor Author

Added more cases with cursor, with/without attributes.

@roman-khimov roman-khimov merged commit 4cd352a into master Feb 25, 2025
3 of 7 checks passed
@roman-khimov roman-khimov deleted the ezayats/searchv2 branch February 25, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test searchv2
3 participants