Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new object search #676

Merged
merged 8 commits into from
Jan 10, 2025

client: Change `SearchObjects` method's signature to more practical form

71d457a
Select commit
Loading
Failed to load commit list.
Merged

Support new object search #676

client: Change `SearchObjects` method's signature to more practical form
71d457a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 9, 2025 in 0s

60.23% (-0.23%) compared to 5f693d2

View this Pull Request on Codecov

60.23% (-0.23%) compared to 5f693d2

Details

Codecov Report

Attention: Patch coverage is 54.32099% with 185 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (5f693d2) to head (71d457a).

Files with missing lines Patch % Lines
proto/object/types.pb.go 40.84% 42 Missing ⚠️
proto/container/service.pb.go 0.00% 29 Missing ⚠️
proto/object/service_grpc.pb.go 0.00% 25 Missing ⚠️
proto/netmap/service.pb.go 0.00% 12 Missing ⚠️
proto/session/types.pb.go 8.33% 11 Missing ⚠️
proto/netmap/types.pb.go 0.00% 10 Missing ⚠️
proto/refs/types.pb.go 0.00% 9 Missing ⚠️
proto/reputation/service.pb.go 0.00% 8 Missing ⚠️
proto/acl/types.pb.go 0.00% 7 Missing ⚠️
proto/reputation/types.pb.go 0.00% 5 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   60.45%   60.23%   -0.23%     
==========================================
  Files         165      165              
  Lines       22238    22683     +445     
==========================================
+ Hits        13444    13663     +219     
- Misses       8449     8674     +225     
- Partials      345      346       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov