Support new object search #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for the purity of coming changes. The `interface{}` declarations
became `any`.
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 60.45% 60.23% -0.23%
==========================================
Files 165 165
Lines 22238 22683 +445
==========================================
+ Hits 13444 13663 +219
- Misses 8449 8674 +225
- Partials 345 346 +1 ☔ View full report in Codecov by Sentry. |
71f42c3 to
d5b0d83
Compare
From nspcc-dev/neofs-api@e66b25d. Brought container's meta information consistency attribute declaration along several with doc improvements. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
From nspcc-dev/neofs-api@d5777f8. Importers of related generated code break, but the previous typedef is not left: direct import is expected only in system code. It is fixed. Functionality supporting the new feature on the API client will be provided later. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Fix `intrange` linter remarks. Refs #552. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
d5b0d83 to
d068413
Compare
roman-khimov
reviewed
Jan 9, 2025
In the original presentation, parameters' optionality followed from the protocol. However, in practice, the opposite is expected: - some objects are filtered out; - attributes' values are in demand; - `for` loop mostly used for gathering, so cursor is always set; - count is rarely limited. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov
approved these changes
Jan 9, 2025
carpawell
approved these changes
Jan 10, 2025
original change followed already used approach on optionality of parameters, and was legit overall. #676 (comment) proposed API with better practical potential, so i decided to add it above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in nspcc-dev/neofs-api#314