Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CID to prevent incorrect usage in netmap #396

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Use CID to prevent incorrect usage in netmap #396

merged 2 commits into from
Apr 21, 2023

Conversation

smallhive
Copy link
Contributor

close #216

@smallhive smallhive requested a review from roman-khimov April 19, 2023 04:43
cthulhu-rider
cthulhu-rider reviewed Apr 19, 2023
View reviewed changes
@smallhive smallhive force-pushed the 216-pivot-for-container-placement branch 2 times, most recently from 3984194 to 735b17b Compare April 19, 2023 11:02
@cthulhu-rider
Copy link
Contributor

@smallhive btw how about https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/netmap#NetMap.PlacementVectors? if u wanna refactor it in a separate PR then current one shouldn't close an issue.

@smallhive smallhive force-pushed the 216-pivot-for-container-placement branch from 735b17b to 079fd8a Compare April 19, 2023 13:47
@smallhive
Copy link
Contributor Author

Completed in this PR

roman-khimov
roman-khimov requested changes Apr 19, 2023
View reviewed changes
@smallhive smallhive force-pushed the 216-pivot-for-container-placement branch from 079fd8a to 694bba6 Compare April 20, 2023 03:52
@smallhive smallhive force-pushed the 216-pivot-for-container-placement branch from 694bba6 to 1afe363 Compare April 20, 2023 04:00
@roman-khimov
Copy link
Member

There is some problem with tests though.

@smallhive
Copy link
Contributor Author

Yes, known issue. Me and @cthulhu-rider investigating it

@smallhive
netmap: Use CID to prevent incorrect usage in netmap
4b6965f 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive
doc: Actualize docs for ContainerNodes func
83ca99a 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 216-pivot-for-container-placement branch from 1afe363 to 83ca99a Compare April 21, 2023 06:25
@smallhive
Copy link
Contributor Author

Tests problems were solved

@roman-khimov roman-khimov merged commit dbbb22c into master Apr 21, 2023
@roman-khimov roman-khimov deleted the 216-pivot-for-container-placement branch April 21, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pivot for container placement
3 participants
@smallhive @cthulhu-rider @roman-khimov