Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROOT filter for SearchV2 #3166

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Fix ROOT filter for SearchV2 #3166

merged 3 commits into from
Feb 21, 2025

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider
node/metabase: Refactor ROOT metadata parameterization
40cd83d 
To simplify relation with parent presence.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
node/metabase: Fix ROOT unit tests for SearchV2
d830e6e 
According to the protocol, only objects of REGULAR type can match ROOT
filter.

This also reveals corresponding implementation bug.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
object/searchv2: Fix non-regular object matching to ROOT filter
032e3a9 
According to the protocol, only objects of REGULAR type can match ROOT
filter.

Also fix corresponding unit test.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider force-pushed the object-searchv2/root-irregular branch from 35959ff to 032e3a9 Compare February 21, 2025 10:18
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.01%. Comparing base (d9c3652) to head (032e3a9).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/local_object_storage/metabase/version.go 50.00% 0 Missing and 2 partials ⚠️
pkg/local_object_storage/metabase/put.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
- Coverage   23.01%   23.01%   -0.01%     
==========================================
  Files         756      756              
  Lines       60210    60211       +1     
==========================================
- Hits        13860    13858       -2     
- Misses      45357    45360       +3     
  Partials      993      993

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review February 21, 2025 10:32
@roman-khimov roman-khimov merged commit 69e69fb into master Feb 21, 2025
21 of 22 checks passed
@roman-khimov roman-khimov deleted the object-searchv2/root-irregular branch February 21, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthulhu-rider @roman-khimov