SearchV2 #314
Merged
SearchV2 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa487dc to
efed121
Compare
carpawell
reviewed
Dec 23, 2024
ef8362f to
1c33ecf
Compare
cthulhu-rider
previously approved these changes
Dec 23, 2024
carpawell
reviewed
Dec 23, 2024
1. Additional fields allow to avoid HEADs in most cases since applications tend to use 1-2 fields to choose between results/check for flags and pick the object they want to GET. Or they just want to have some fields to display object list, but they don't need a full HEAD. 2. Sorting is critical here, absent sorting we can't limit reply in number of elements returned and we can't have cursors to continue search. 3. Limits on number of returned elements allow to use single message instead of a stream. 4M of the default message fits 256 full-sized 16K headers and we expect just a few attributes in fact, so 1000 elements shouldn't be a problem. 4. We can't go backwards with the order easily, so this is omitted for now. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
No functional changes. Signed-off-by: Roman Khimov <roman@nspcc.ru>
1c33ecf to
7d66fb0
Compare
carpawell
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.