Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check popped context in RET opcode #1220

Closed
fyrchik opened this issue Jul 22, 2020 · 1 comment · Fixed by #1228
Closed

Check popped context in RET opcode #1220

fyrchik opened this issue Jul 22, 2020 · 1 comment · Fixed by #1228
Assignees
@fyrchik
Labels
vm VM tasks/bugs/issues

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Jul 22, 2020 •
edited
Loading

Investigate on whether this condition can be true. https://github.com/nspcc-dev/neo-go/blob/master/pkg/vm/vm.go#L1298

  1. It is not covered by any test.
  2. Upon loading new context, we set it's evalutation stack to that of VM.

Possibly (2) is not the thing we need to do in LoadScript and behavior is different for function calls vs. contract calls.
EIther write a test which covers this condition or remove it.
@fyrchik fyrchik mentioned this issue Jul 23, 2020
Merged
@fyrchik
Copy link
Contributor Author

fyrchik commented Jul 23, 2020

Should be done after #1181 .

@fyrchik fyrchik mentioned this issue Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
vm VM tasks/bugs/issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust System.Contract.Call.* interops nspcc-dev/neo-go
1 participant
@fyrchik