Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): allow force ignore of logs from nxViteTsPaths plugin #29320 #30200

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 27, 2025

Current Behavior

When Vite build is run where:

  • nxViteTsPaths plugin is enabled
  • --verbose or NX_VERBOSE_LOGGING=true is set

The resulting logs can be quite noisy.

Expected Behavior

When debug is explicitly set to false, ignore logs even when --verbose is passed.

Usage:

nxViteTsPaths({ debug: false })

Related Issue(s)

Fixes #29320

@Coly010 Coly010 self-assigned this Feb 27, 2025
@Coly010 Coly010 requested a review from a team as a code owner February 27, 2025 11:37
@Coly010 Coly010 requested a review from jaysoo February 27, 2025 11:37
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 2:11pm

Copy link

nx-cloud bot commented Feb 27, 2025

View your CI Pipeline Execution ↗ for commit fe8ac38.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 37s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 14:44:12 UTC

@Coly010 Coly010 force-pushed the vite/ts-paths-logging branch from 371c907 to 0a2a6ba Compare February 27, 2025 13:02
@Coly010 Coly010 changed the title fix(vite): allow force-ignore of logs from nxViteTsPaths plugin #29320 fix(vite): allow force ignore of logs from nxViteTsPaths plugin #29320 Feb 27, 2025
@@ -24,6 +24,7 @@ import { isUsingTsSolutionSetup } from '@nx/js/src/utils/typescript/ts-solution-
export interface nxViteTsPathsOptions {
/**
* Enable debug logging
* If set to 'force-ignore', it will always ignore the debug logging even when `--verbose` or `NX_VERBOSE_LOGGING` is set to true.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the mention of force-ignore

Coly010 and others added 2 commits February 27, 2025 14:06
Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@Coly010 Coly010 merged commit 4fe4fe9 into master Feb 27, 2025
12 checks passed
@Coly010 Coly010 deleted the vite/ts-paths-logging branch February 27, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nx Vite TsPaths] Unable to resolve any file
2 participants