feat(react): add react-router plugin #29965
Open
+823
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit effb167.
☁️ Nx Cloud last updated this comment at |
408f6f5 to
10c8669
Compare
10c8669 to
a63d6a3
Compare
a63d6a3 to
5ae1617
Compare
jaysoo
reviewed
Feb 12, 2025
Coly010
requested changes
Feb 13, 2025
e940cb9 to
de96660
Compare
Coly010
approved these changes
Feb 13, 2025
988545d to
dfa21e7
Compare
dfa21e7 to
effb167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the React Router plugin in Nx.
The new functionality adds a react-router plugin entry into
nx.json, projects that are React-Router V7 viareact-router.config.(m|c)?[jt]swill have their targets inferred.Changes
Update the React plugin to have a react-router (RR V7) plugin export.
The RR V7 will only infer targets if we have a
react-router.config.(m|c)?[jt]sand also avite.config.(m|c)?[jt]s.Under the hood the RR V7 CLI uses vite for compilation.
That being said, apps are not limited to only use vite for RR V7. Should you choose to use it the compilation will not be done via RR V7 CLI.