Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nrwl/web:rollup produces the wrong output #8475

Closed
NetanelBasal opened this issue Jan 11, 2022 · 3 comments
Closed

@nrwl/web:rollup produces the wrong output #8475

NetanelBasal opened this issue Jan 11, 2022 · 3 comments
Labels
outdated scope: react Issues related to React support for Nx type: bug

Comments

@NetanelBasal
Copy link

Current Behavior

When using the following configuration:

    "build": {
      "executor": "@nrwl/web:rollup",
      "outputs": [
        "{options.outputPath}"
      ],
      "options": {
        "outputPath": "dist/packages/falso",
        "tsConfig": "packages/falso/tsconfig.lib.json",
        "project": "packages/falso/package.json",
        "entryFile": "packages/falso/src/index.ts",
        "format": [
          "esm",
          "cjs"
        ]
      }
    },

The build output in package.json is:

  "main": "./index.umd.js",
  "module": "./index.esm.js",
  "typings": "./index.d.ts"

Expected Behavior

  "main": "./index.cjs.js",
  "module": "./index.esm.js",
  "typings": "./index.d.ts"
@NetanelBasal
Copy link
Author

Screen Shot 2022-01-11 at 22 18 41

The issue is here. It doesn't take into account the provided format.

@jaysoo
Copy link
Member

jaysoo commented May 30, 2022

This is fixed in latest Nx version (14.1.9)

@jaysoo jaysoo closed this as completed May 30, 2022
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react Issues related to React support for Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants