Skip to content

Commit

Permalink
feat(node): generate new apps with continuous: true
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Feb 24, 2025
1 parent 1dfc8cb commit e003351
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ describe('app', () => {
"buildTarget": "myapp:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down
2 changes: 2 additions & 0 deletions packages/nest/src/generators/application/application.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ describe('application generator', () => {
"buildTarget": "my-node-app:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down Expand Up @@ -238,6 +239,7 @@ describe('application generator', () => {
"buildTarget": "myapp:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down
3 changes: 3 additions & 0 deletions packages/node/src/generators/application/application.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ describe('app', () => {
"buildTarget": "my-node-app:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down Expand Up @@ -263,6 +264,7 @@ describe('app', () => {
"buildTarget": "my-node-app:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down Expand Up @@ -626,6 +628,7 @@ describe('app', () => {
"buildTarget": "myapp:build:production",
},
},
"continuous": true,
"defaultConfiguration": "development",
"dependsOn": [
"build",
Expand Down
15 changes: 12 additions & 3 deletions packages/node/src/generators/application/application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ function getEsBuildConfig(

function getServeConfig(options: NormalizedSchema): TargetConfiguration {
return {
continuous: true,
executor: '@nx/js:node',
defaultConfiguration: 'development',
// Run build, which includes dependency on "^build" by default, so the first run
Expand Down Expand Up @@ -290,10 +291,18 @@ function addAppFiles(tree: Tree, options: NormalizedSchema) {

function addProxy(tree: Tree, options: NormalizedSchema) {
const projectConfig = readProjectConfiguration(tree, options.frontendProject);
if (projectConfig.targets && projectConfig.targets.serve) {
if (
projectConfig.targets &&
['serve', 'dev'].find((t) => !!projectConfig.targets[t])
) {
const targetName = ['serve', 'dev'].find((t) => !!projectConfig.targets[t]);
projectConfig.targets[targetName].dependsOn = [
...(projectConfig.targets[targetName].dependsOn ?? []),
`${options.name}:serve`,
];
const pathToProxyFile = `${projectConfig.root}/proxy.conf.json`;
projectConfig.targets.serve.options = {
...projectConfig.targets.serve.options,
projectConfig.targets[targetName].options = {
...projectConfig.targets[targetName].options,
proxyConfig: pathToProxyFile,
};

Expand Down

0 comments on commit e003351

Please sign in to comment.