Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

"fetch failed" logged without retry information #6644

Closed
arty-name opened this issue Nov 5, 2014 · 3 comments
Closed

"fetch failed" logged without retry information #6644

arty-name opened this issue Nov 5, 2014 · 3 comments

Comments

@arty-name
Copy link

When running npm install in normal mode without -d it sometimes reports fetch errors but finishes successfully. Install is successful because npm attempts fetching several times. However it's not clear from the logs.

I propose reporting fetch errors only when all the attempts fail. Another option is to log "fetch failed, will retry".

@othiym23
Copy link
Contributor

Another option is to log "fetch failed, will retry".

This is what I think makes the most sense. If somebody wanted to put together a patch with this tweak to the error message (it probably belongs in npm-registry-client), it would be welcomed.

@othiym23
Copy link
Contributor

The default message is fine, but it doesn't get displayed by default anymore, because the default logging level is warn, and those messages were being logged at info, which is lower priority. Since these really are warnings, go ahead and log them as such. Landed as 9bb2c34.

@arty-name
Copy link
Author

Thanks, that option also works for me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants