-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] npm v9.0.0: src/, dist/ was not packed #5741
Closed
2 tasks done
Labels
Bug
thing that needs fixing
Priority 1
high priority issue
Release 9.x
work is associated with a specific npm 9 release
Comments
The The entries in |
~/D/n/s/pack $ cat package.json
{
"name": "pack",
"version": "1.0.0",
"description": "",
"main": "index.js",
"files": [
"src/",
"dist/"
],
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "Gar <gar+npm@danger.computer>",
"license": "ISC"
}
~/D/n/s/pack $ npm pack --dry-run
npm notice
npm notice 📦 pack@1.0.0
npm notice === Tarball Contents ===
npm notice 0B dist/foo
npm notice 289B package.json
npm notice 0B src/bar |
sounds a regression: #4850 (comment) I didn't see it was mentioned in the release note, if you want it to be a breaking change. |
It was introduced in npm@9 w/ the packlist refactor. cc @nlf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
thing that needs fixing
Priority 1
high priority issue
Release 9.x
work is associated with a specific npm 9 release
Is there an existing issue for this?
This issue exists in the latest npm version
Current Behavior
Expected Behavior
the files in
"src/"
and"dist/"
should be packed.I've confirmed it's working fine with npm v8.
Steps To Reproduce
Environment
; copy and paste output from `npm config ls` here
The text was updated successfully, but these errors were encountered: