Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade node-gyp to ^8.1.2 version #3525

Closed
1 task done
altro3 opened this issue Jul 8, 2021 · 1 comment
Closed
1 task done

[BUG] Upgrade node-gyp to ^8.1.2 version #3525

altro3 opened this issue Jul 8, 2021 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@altro3
Copy link

altro3 commented Jul 8, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I run yarn install, see these warnings

warning npm > node-gyp > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning npm > node-gyp > request > uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.
  See https://v8.dev/blog/math-random for details.
warning npm > node-gyp > request > har-validator@5.1.5: this library is no longer supported

Expected Behavior

Need to upgrade dependency "node-gyp": "^7.1.2" to "node-gyp": "^8.1.2" - it already uses node-fetch (see pull request nodejs/node-gyp#2220)

Steps To Reproduce

  1. In this environment...
  2. With this config...
  3. Run '...'
  4. See error...

Environment

  • OS: Windows 10
  • Node: 16.4.2
  • npm: 7.19.1
@altro3 altro3 added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Jul 8, 2021
@altro3 altro3 changed the title [BUG] <title> [BUG] Upgrade node-gyp to ^8.1.2 version Jul 8, 2021
@wraithgar
Copy link
Member

Updating node-gyp is on our roadmap, but it may not be able to happen until npm@8 because it is a breaking change and is not supported in node versions 10.0.0 through 10.11.0, which npm@7 has to support. It also drops support for some python versions, and we are discussing whether or not that also prevents us from updating in this npm version.

You can see the ongoing discussion here nodejs/node-gyp#2392

The bug that prevents users from specifying their own node-gyp version is being tracked here #2839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

2 participants