Skip to content

Commit

Permalink
chore(deps): tar v6 and mkdirp v1
Browse files Browse the repository at this point in the history
BREAKING CHANGE: bumps engines to >= 10
  • Loading branch information
isaacs committed Jan 28, 2020
1 parent f96e40d commit 5a66e7a
Show file tree
Hide file tree
Showing 5 changed files with 102 additions and 19 deletions.
2 changes: 1 addition & 1 deletion lib/util/fix-owner.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const util = require('util')

const chownr = util.promisify(require('chownr'))
const mkdirp = util.promisify(require('mkdirp'))
const mkdirp = require('mkdirp')
const inflight = require('promise-inflight')
const inferOwner = require('infer-owner')

Expand Down
99 changes: 94 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,13 @@
"minipass-collect": "^1.0.2",
"minipass-flush": "^1.0.5",
"minipass-pipeline": "^1.2.2",
"mkdirp": "^0.5.1",
"mkdirp": "^1.0.3",
"move-concurrently": "^1.0.1",
"p-map": "^3.0.0",
"promise-inflight": "^1.0.1",
"rimraf": "^2.7.1",
"ssri": "^7.0.0",
"tar": "^6.0.0",
"unique-filename": "^1.1.1"
},
"devDependencies": {
Expand All @@ -93,6 +94,6 @@
"100": true
},
"engines": {
"node": ">= 8"
"node": ">= 10"
}
}
8 changes: 2 additions & 6 deletions test/util.fix-owner.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ test('uses infer-owner ids instead of process-retrieved if valid', (t) => {

test('attempt to mkdirfix existing path', (t) => {
const fixOwner = getFixOwner({
mkdirp: function mkdirp (path, cb) {
cb(pathExistsError)
}
mkdirp: () => Promise.reject(pathExistsError)
})

t.plan(1)
Expand All @@ -212,9 +210,7 @@ test('attempt to mkdirfix existing path', (t) => {

test('attempt to mkdirfix unknown error', (t) => {
const fixOwner = getFixOwner({
mkdirp: function mkdirp (path, cb) {
cb(genericError)
}
mkdirp: () => Promise.reject(genericError)
})

t.plan(1)
Expand Down
7 changes: 2 additions & 5 deletions test/util/test-dir.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,9 @@ function reset (testDir, cb) {
if (err) {
return cb(err)
}
mkdirp(testDir, function (err) {
if (err) {
return cb(err)
}
mkdirp(testDir).then(() => {
process.chdir(testDir)
cb()
})
}, cb)
})
}

0 comments on commit 5a66e7a

Please sign in to comment.