From 5530898bab257bba06a7e5c5e49b049e0595b070 Mon Sep 17 00:00:00 2001 From: Stephen Vickers Date: Mon, 29 Feb 2016 13:38:21 +0000 Subject: [PATCH] #5 Wrong callback called in the `traceRoute()` method when a session ID cannot be generated --- .gitignore | 1 + .hgignore | 2 -- README.md | 5 +++++ index.js | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 .gitignore delete mode 100644 .hgignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..3c3629e --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +node_modules diff --git a/.hgignore b/.hgignore deleted file mode 100644 index 13cfce5..0000000 --- a/.hgignore +++ /dev/null @@ -1,2 +0,0 @@ -syntax: glob -node_modules diff --git a/README.md b/README.md index a399562..de9fd49 100644 --- a/README.md +++ b/README.md @@ -455,6 +455,11 @@ Bug reports should be sent to . * Host repository on GitHub +## Version 1.2.0 - 29/02/2016 + + * Wrong callback called in the `traceRoute()` method when a session ID cannot + be generated + # Roadmap Suggestions and requirements should be sent to . diff --git a/index.js b/index.js index 2959731..75b0132 100644 --- a/index.js +++ b/index.js @@ -496,7 +496,7 @@ Session.prototype.traceRoute = function (target, ttl, feedCallback, var id = this._generateId (); if (! id) { var sent = new Date (); - callback (new Error ("Too many requests outstanding"), target, + doneCallback (new Error ("Too many requests outstanding"), target, sent, sent); return this; }