Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing custom selector instead of label for actions #10

Closed
mondaychen opened this issue Feb 12, 2024 · 2 comments · Fixed by #35
Closed

Allow providing custom selector instead of label for actions #10

mondaychen opened this issue Feb 12, 2024 · 2 comments · Fixed by #35
Assignees

Comments

@mondaychen
Copy link
Contributor

No description provided.

@lynchee-owo
Copy link
Contributor

lynchee-owo commented Mar 1, 2024

TODO:

  • export 4 types: the main action type and three sub action types (selector, label, and elementId)
  • export a generic performAction that calls three sub performActions{selector/label/elementId} based on action type.
  • refactor available actions

Test and Release:

  • change npm package version (beta) in package.lib.json
  • run the build lib script to generate dist-lib
  • run npm publish --tag beta2 in dist-lib
  • now the new version is published. use that in wingmate to test
  • if things are working properly, publish the official version (remove beta tag)

@lynchee-owo
Copy link
Contributor

bugs found when completing this task:

  1. the fallback selector (visible-text) cannot be properly applied such that the corresponding element cannot be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants