Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS 4.9 #82

Closed
Alexandre-Fernandez opened this issue Nov 16, 2022 · 6 comments
Closed

TS 4.9 #82

Alexandre-Fernandez opened this issue Nov 16, 2022 · 6 comments
Labels
Awaiting Upstream Fix

Comments

@Alexandre-Fernandez
Copy link

I'm using ts-patch with the typescript-transform-paths plugin and it looks like the new typescript update broke it, I switched back to TS 4.8.4 and it works again.
@nonara
Copy link
Owner

nonara commented Nov 17, 2022 •
edited
Loading

Thank you for the report.

Another user recently reported a regression in TS 4.9 that broke the visitEachChild function. He submitted a PR and they are planning to merge it.

@nonara
Copy link
Owner

nonara commented Nov 17, 2022

This is the issue

microsoft/TypeScript#51542

Looks like this is pretty broad, so I'm assuming we need to wait on TS to release the patch.

@bradennapier
Copy link

More likely to be ovos/zerollup#1 ?

@nonara
Copy link
Owner

nonara commented Nov 22, 2022

More likely to be ovos/zerollup#1 ?

I don't think so, no. I accommodated 4.8 changes:

@DanielRosenwasser
Copy link

4.9.4 is now out FWIW

@nonara
Copy link
Owner

nonara commented Dec 8, 2022

ts 4.9.4 support is added in ts-patch v2.1.0

@nonara nonara closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Upstream Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DanielRosenwasser @nonara @bradennapier @Alexandre-Fernandez