Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an alert after 3 consecutive errors #9

Open
tomlebl opened this issue Sep 27, 2022 · 1 comment
Open

Send an alert after 3 consecutive errors #9

tomlebl opened this issue Sep 27, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tomlebl
Copy link
Contributor

tomlebl commented Sep 27, 2022

If there are 3 consecutive errors IconNMR run stops. In that case, it would be useful to sent an e-mail alert to admins.

@tomlebl tomlebl added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2022
@tomlebl tomlebl moved this to Backlog in NOMAD system Sep 27, 2022
@tomlebl
Copy link
Contributor Author

tomlebl commented Nov 27, 2022

There could be more complicated logic for error handling that could make the system more resilient by avoiding unnecessary stops of IconNMR after 3 consecutive errors .

Number of consecutive error can be set by admin
If defined number of last entries in history table has "Error" status, NOMAD submits an experiment with priority for a standard sample that permanently sits in the last holder of sample changer. If tracker detects that the standard experiments gets error then NOMAD shuts the queue and sends error message to admins.
If there would be other samples waiting in the queue, we will get race condition here. Thus, the standard sample can go in just after the errors or after next experiment
That should not be a big problem as we can simply disable the feature in IconNMR or set the value of consecutive error to +2. In that case, if standard sample gets through successfully IconNMR error sequence gets interrupted and machine keeps running.

@tomlebl tomlebl moved this from Backlog to Todo in NOMAD system Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant