Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to update but there's a number of missing resources #106

Open
remy opened this issue May 14, 2023 · 3 comments · May be fixed by #107
Open

Trying to update but there's a number of missing resources #106

remy opened this issue May 14, 2023 · 3 comments · May be fixed by #107

Comments

@remy
Copy link

remy commented May 14, 2023

I've tried to update this locally (me and my daughter playing Pokémon Legends Arceus for instance couldn't find Rowlet), but there's a number of issues.

Two that stand out:

  1. src/js/shared/data/monsterSummaries.json isn't synced or updated from the data anywhere I could find. I mostly managed to generate it using the following jq command: [.. | .docs? | select(.)[] ] | map({ name, types, national_id }) based on slurped data from src/assets/skim-monsters.txt - but I'm not sure if it's right (as it doesn't include the resource_uri - but searching the codebase, I couldn't see that prop being used).
  2. More importantly, the base64 encoded images in sprites.css - I can't find where or if this file is regenerated. I gather it comes from the front_default from the pokeapi, but I can't see where this is being built.

I'd be happy to upgrade and update, I just want to rule out that I've missed these things before I write them myself.

@nolanlawson
Copy link
Owner

This project is not really maintained; I'm sorry about that. You might try https://bulbapedia.bulbagarden.net or one of the other online pokedexes.

@remy
Copy link
Author

remy commented May 14, 2023

I've actually managed to make a bit of progress (but sorry, I only noticed the "not maintained" badge after I posted the issue!).

I've got the database updated and returning in results. I've also managed to scrape down the missing images and am in the progress of converting to base64 (kinda find it odd that there's a number of webp images that come up larger than png… it's not something I expected).

I've got one final bug to squash where the entire monster page is blank in some of the newer pokemon (my guess is that there's some other data missing, but there's no errors).

If I managed to get a working PR, would you want to release it to pokedex.org? If not, totally cool - I've got enough hosted under my own belt (and like I said, it was for me and my girl anyway).

Cheers chap.

@remy
Copy link
Author

remy commented May 14, 2023

Hmm, just noting for myself mostly, but I've found code that actually did handle all the 802 pokemon - since it's a limit on a for loop in the build scripts - but for some reason the pokedex conked out at 649. I'm not quite sure why, but I suspect the source monsterSummaries had been built with the 649 pokemon.

I've nearly solved the empty pages for pokemon 764 and upwards (nothing like digging around 8 year old code from someone else :D )

@remy remy linked a pull request May 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants