Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression testing to track that callstacks are correct #7207

Closed
TomAFrench opened this issue Jan 28, 2025 · 0 comments · Fixed by #7233
Closed

Add regression testing to track that callstacks are correct #7207

TomAFrench opened this issue Jan 28, 2025 · 0 comments · Fixed by #7233
Assignees
@michaeljklein

Comments

@TomAFrench
Copy link
Member

We've recently had a regression where some callstacks were partially reversed. We currently don't have any tracking for the correctness of these so we should add some tests which compile a program, purposefully trigger a revert and then checks the callstack is correct.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 28, 2025
@michaeljklein michaeljklein mentioned this issue Jan 29, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: regression test #7195 noir-lang/noir
2 participants
@michaeljklein @TomAFrench