Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public inputs should be easy to parse into human readable values #3547

Closed
TomAFrench opened this issue Nov 23, 2023 · 0 comments · Fixed by #3543
Closed

Public inputs should be easy to parse into human readable values #3547

TomAFrench opened this issue Nov 23, 2023 · 0 comments · Fixed by #3543
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

It's important to be able to decode the public inputs attached to a proof however the way that JS code is returning these is not ideal. It's instead a flattened and deduplicated array of Uint8Arrays.

This then requires a good deal of knowledge on behalf of the user to be able to decode these values and interpret them.

Happy Case

We should perform a conversion from this array into a WitnessMap inside noir_js_backend_barretenberg. Once this is done a user can get human readable values out by just abi decoding the witness map.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@TomAFrench TomAFrench added the enhancement New feature or request label Nov 23, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 23, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant