Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noir-wasm nodeJs testing #2326

Closed
kevaundray opened this issue Aug 15, 2023 · 3 comments · Fixed by #2387
Closed

Noir-wasm nodeJs testing #2326

kevaundray opened this issue Aug 15, 2023 · 3 comments · Fixed by #2387
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Currently it does not seem possible to run tests of noir-wasm using nodeJs

Happy Case

We can run tests using NodeJs aswell as the browser

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Aug 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 15, 2023
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Aug 16, 2023

Could you elaborate a bit on what does "not possible" mean?

We had #1921 that introduced Node.js-based tests. Did something break?

Headless browser tests are something we plan to tackle next (after bb.js tests): #2163

@kevaundray
Copy link
Contributor Author

Could you elaborate a bit on what does "not possible" mean?

We had #1921 that introduced Node.js-based tests. Did something break?

Headless browser tests are something we plan to tackle next (after bb.js tests): #2163

Hmm where are the node JS tests in that? I only see browser tests being called

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Aug 21, 2023

Ah right we are only running yarn test:browser albeit having this. Thanks Kev.

cc @jonybur @kobyhallx adding this to the "Noir Packages - Alpha Release" project on our board.

@kobyhallx kobyhallx self-assigned this Aug 25, 2023
@Savio-Sou Savio-Sou linked a pull request Aug 30, 2023 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants