You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we used Brillig foreign calls for printing to stdout we no longer need the ACIR based Println instruction as the builtin no longer exists in the stdlib. The Log directive can also then be removed from ACIR as other callers should also be using Brillig foreign calls to implement printing.
Happy Case
Remove Intrinsic::Println and any of its uses. It is also used for some of the SSA tests so these tests should be updated to use a new intrinsic such as ToBits or Sort.
Alternatives Considered
N/A - otherwise we are leaving dead code in the ACIR generation
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Problem
Now that we used Brillig foreign calls for printing to stdout we no longer need the ACIR based Println instruction as the builtin no longer exists in the stdlib. The Log directive can also then be removed from ACIR as other callers should also be using Brillig foreign calls to implement printing.
Happy Case
Remove Intrinsic::Println and any of its uses. It is also used for some of the SSA tests so these tests should be updated to use a new intrinsic such as
ToBits
orSort
.Alternatives Considered
N/A - otherwise we are leaving dead code in the ACIR generation
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: