Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise properties of Truncate instruction #1604

Closed
joss-aztec opened this issue Jun 8, 2023 · 3 comments
Closed

Rationalise properties of Truncate instruction #1604

joss-aztec opened this issue Jun 8, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@joss-aztec
Copy link
Contributor

Problem

Some properties of the current Truncate instruction are potentially not beneficial to the SSA passes planned to operate of them, and are possibly leaking an implementation detail from ACIR-gen.

Happy Case

Create a clearer separation between the truncation information required for the SSA passes, and the truncation information that ACIR-gen can conveniently infer itself.

This may involve removing properties from the instruction, or perhaps even removing the instruction is favour of encoding it as a property on binary operator.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@joss-aztec joss-aztec added the enhancement New feature or request label Jun 8, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 8, 2023
@joss-aztec
Copy link
Contributor Author

Backlink: #1568 (comment)

@kevaundray
Copy link
Contributor

In normal euclidean division, q is not explicitly bounded, so we should provide a rationale as to why we do it here

@guipublic
Copy link
Contributor

I am closing the issue since the integer division is now correct.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants