diff --git a/.github/workflows/test-js-packages.yml b/.github/workflows/test-js-packages.yml index c7b4f1d9f65..498d5160e27 100644 --- a/.github/workflows/test-js-packages.yml +++ b/.github/workflows/test-js-packages.yml @@ -534,7 +534,7 @@ jobs: - name: Build list of libraries id: get_critical_libraries run: | - LIBRARIES=$(yq ./EXTERNAL_NOIR_LIBRARIES.yml -o json | jq -c '.libraries | map({ repo, path: (.path // ""), timeout, nargo_args })') + LIBRARIES=$(yq ./EXTERNAL_NOIR_LIBRARIES.yml -o json | jq -c '.libraries | map({ repo, path: (.path // ""), timeout:(.timeout // 2), nargo_args })') echo "libraries=$LIBRARIES" echo "libraries=$LIBRARIES" >> $GITHUB_OUTPUT env: @@ -620,7 +620,7 @@ jobs: run: .github/scripts/check_test_results.sh .github/critical_libraries_status/${{ matrix.project.repo }}/${{ matrix.project.path }}.failures.jsonl .github/critical_libraries_status/${{ matrix.project.repo }}/${{ matrix.project.path }}.actual.jsonl - name: Upload test report - if: ${{ matrix.project.timeout > 10 }} # We want to recording benchmarking for a ton of tiny libraries, these should be covered with aggressive timeouts + if: ${{ matrix.project.timeout > 10 }} # We want to avoid recording benchmarking for a ton of tiny libraries, these should be covered with aggressive timeouts uses: actions/upload-artifact@v4 with: name: ${{ steps.test_report.outputs.test_report_name }} diff --git a/EXTERNAL_NOIR_LIBRARIES.yml b/EXTERNAL_NOIR_LIBRARIES.yml index c9afcf8b4dc..f9b4d6cc07d 100644 --- a/EXTERNAL_NOIR_LIBRARIES.yml +++ b/EXTERNAL_NOIR_LIBRARIES.yml @@ -36,31 +36,41 @@ libraries: timeout: 2 noir_rsa: repo: noir-lang/noir_rsa + timeout: 2 noir_json_parser: repo: noir-lang/noir_json_parser + timeout: 10 aztec_nr: repo: AztecProtocol/aztec-packages path: noir-projects/aztec-nr + timeout: 60 noir_contracts: repo: AztecProtocol/aztec-packages path: noir-projects/noir-contracts + timeout: 60 blob: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/blob + timeout: 70 protocol_circuits_parity_lib: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/parity-lib + timeout: 4 protocol_circuits_private_kernel_lib: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/private-kernel-lib + timeout: 250 protocol_circuits_reset_kernel_lib: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/reset-kernel-lib + timeout: 15 protocol_circuits_types: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/types + timeout: 60 protocol_circuits_rollup_lib: repo: AztecProtocol/aztec-packages path: noir-projects/noir-protocol-circuits/crates/rollup-lib + timeout: 300 # Use 1 test threads for rollup-lib because each test requires a lot of memory, and multiple ones in parallel exceed the maximum memory limit. nargo_args: "--test-threads 1"