Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumb hasn't min height #41

Closed
vlukyanoff opened this issue Mar 3, 2017 · 4 comments
Closed

Thumb hasn't min height #41

vlukyanoff opened this issue Mar 3, 2017 · 4 comments

Comments

@vlukyanoff
Copy link

If there lots of elements in scrollable view, thumb is very small

@noeldelgado
Copy link
Owner

Hi @vlukyanoff, I just published a new version (v1.5.0) which adds a new config option minThumbSize, its default value is 20(px) [941455b].

Please let me know if that works for you.

Cheers.

@vlukyanoff
Copy link
Author

Hi @noeldelgado, I tested version 1.5.0, it works how I expected, thanks a lot!

Could you update dependency to v1.5.0 in https://github.com/noeldelgado/react-gemini-scrollbar ?

@noeldelgado
Copy link
Owner

Hi Viacheslav, thanks for testing!

There is one thing I have to make sure before I update the dependency on react-gemini... in version 1.4.x of gemini it was introduced a feature which modifies the DOM structure (which as far as I remember, react does not like that at all), I think you can reproduce the issue by using the new version and appending new elements to the scroll-content dynamically, that will result in reseting the scroll position to zero... I will try to test if the issue is not happening anymore or fix it before I upgrade the dependency version.

Thanks for your help!

@noeldelgado
Copy link
Owner

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants