Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new version (node.js compat < v16) #1372

Closed
dnalborczyk opened this issue Apr 25, 2022 · 1 comment
Closed

Release new version (node.js compat < v16) #1372

dnalborczyk opened this issue Apr 25, 2022 · 1 comment

Comments

@dnalborczyk
Copy link

dnalborczyk commented Apr 25, 2022 •
edited
Loading

I was wondering if a new release could be published.

this PR #1318 fixed an issue with logical assignment syntax not being supported for node.js < v16.

the elasticsearch client adopted undici v5.0 https://github.com/elastic/elastic-transport-js/blob/fabe5f42d6e69aa99cb0a77dda76e7369800d896/package.json#L66 and therefore makes it incompatible with any version below v16.

I must admit that it is a bit surprising that neither the undici tests nor the elasticsearch tests discovered the incompatibility in their tests.
@dnalborczyk dnalborczyk changed the title Release new version Release new version (node.js compat < v16) Apr 25, 2022
@dotansimha dotansimha mentioned this issue May 1, 2022
Closed
@mcollina
Copy link
Member

mcollina commented May 2, 2022

This is done.

@mcollina mcollina closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @dnalborczyk