From f645b4c8da57891c7cf5b59987548e87e32479fb Mon Sep 17 00:00:00 2001 From: Bryan English Date: Mon, 6 Jun 2016 16:28:50 -0700 Subject: [PATCH] doc: clarify "Reviewed-By" iff "LGTM" As per conversation with @Trott, make it clear that Reviewed-By lines should only be added for collaborators who've actually put a LGTM on the PR. --- doc/onboarding.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/onboarding.md b/doc/onboarding.md index 99fbc61935c84d..f75a2637413309 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -169,6 +169,7 @@ Landing a PR * `Reviewed-By: human ` * Easiest to use `git log` then do a search * (`/Name` + `enter` (+ `n` as much as you need to) in vim) + * Only include collaborators who have commented "LGTM" * `PR-URL: ` * `git push upstream master` * close the original PR with "Landed in ``".