tools: prepare custom rules for ESLint v9

tools/eslint-rules/no-array-destructuring.js

@@ -56,7 +56,7 @@ module.exports = {
     schema: [],
   },
   create(context) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = context.sourceCode;
 
     return {
       ArrayPattern(node) {

tools/eslint-rules/no-duplicate-requires.js

@@ -25,7 +25,8 @@ function isTopLevel(node) {
   return false;
 }
 
-module.exports = (context) => {
+module.exports = {
+  create(context) {
     if (context.parserOptions.sourceType === 'module') {
       return {};
     }
@@ -62,4 +63,5 @@ module.exports = (context) => {
     };
 
     return rules;
+  },
 };

tools/eslint-rules/no-unescaped-regexp-dot.js

@@ -10,7 +10,7 @@
 
 module.exports = {
   create(context) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = context.sourceCode;
     const regexpStack = [];
     let regexpBuffer = [];
     let inRegExp = false;

tools/eslint-rules/non-ascii-character.js

@@ -24,7 +24,8 @@ const suggestions = {
   '—': '-',
 };
 
-module.exports = (context) => {
+module.exports = {
+  create(context) {
 
     const reportIfError = (node, sourceCode) => {
 
@@ -50,6 +51,7 @@ module.exports = (context) => {
     };
 
     return {
-    Program: (node) => reportIfError(node, context.getSourceCode()),
+      Program: (node) => reportIfError(node, context.sourceCode),
     };
+  },
 };

tools/eslint-rules/prefer-assert-iferror.js

@@ -12,7 +12,7 @@ module.exports = {
     fixable: 'code',
   },
   create(context) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = context.sourceCode;
     let assertImported = false;
 
     function hasSameTokens(nodeA, nodeB) {

tools/eslint-rules/prefer-assert-methods.js

@@ -31,7 +31,7 @@ module.exports = {
             node,
             message: parseError(assertMethod, arg.operator),
             fix: (fixer) => {
-              const sourceCode = context.getSourceCode();
+              const sourceCode = context.sourceCode;
               const left = sourceCode.getText(arg.left);
               const right = sourceCode.getText(arg.right);
               return fixer.replaceText(

tools/eslint-rules/prefer-common-mustsucceed.js

@@ -3,7 +3,8 @@
 const mustCall = 'CallExpression[callee.object.name="common"]' +
                  '[callee.property.name="mustCall"]';
 
-module.exports = (context) => {
+module.exports = {
+  create(context) {
     function isAssertIfError(node) {
       return node.type === 'MemberExpression' &&
             node.object.type === 'Identifier' &&
@@ -63,4 +64,5 @@ module.exports = (context) => {
         }
       },
     };
+  },
 };

tools/eslint-rules/prefer-primordials.js

@@ -75,9 +75,27 @@ module.exports = {
     messages: {
       error: 'Use `const { {{name}} } = primordials;` instead of the global.',
     },
+    schema: {
+      type: 'array',
+      items: [
+        {
+          type: 'object',
+          required: ['name'],
+          properties: {
+            name: { type: 'string' },
+            ignore: {
+              type: 'array',
+              items: { type: 'string' },
+            },
+            into: { type: 'string' },
+          },
+          additionalProperties: false,
+        },
+      ],
+    },
   },
   create(context) {
-    const globalScope = context.getSourceCode().scopeManager.globalScope;
+    const globalScope = context.sourceCode.scopeManager.globalScope;
 
     const nameMap = new Map();
     const renameMap = new Map();
@@ -110,7 +128,7 @@ module.exports = {
         }
         const name = node.name;
         const parent = getDestructuringAssignmentParent(
-          context.getScope(),
+          context.sourceCode.getScope(node),
           node,
         );
         const parentName = parent?.name;
@@ -155,7 +173,7 @@ module.exports = {
         }
 
         const variables =
-          context.getSourceCode().scopeManager.getDeclaredVariables(node);
+          context.sourceCode.scopeManager.getDeclaredVariables(node);
         if (variables.length === 0) {
           context.report({
             node,

tools/eslint-rules/prefer-proto.js

@@ -7,8 +7,8 @@
 'use strict';
 
 // Cribbed from `eslint-module-utils/declaredScope`
-function declaredScope(context, name) {
-  const references = context.getScope().references;
+function declaredScope(context, node, name) {
+  const references = context.sourceCode.getScope(node).references;
   const reference = references.find((x) => x.identifier.name === name);
   if (!reference) return undefined;
   return reference.resolved.scope.type;
@@ -33,12 +33,12 @@ module.exports = {
         [callee.type="MemberExpression"][callee.object.name="Object"][callee.property.name="create"]\
       )'(node) {
         if (node.callee.type === 'MemberExpression') {
-          const scope = declaredScope(context, node.callee.object);
+          const scope = declaredScope(context, node, node.callee.object);
           if (scope && scope !== 'module' && scope !== 'global') {
             return;
           }
         }
-        const value = context.getSourceCode().getText(node.arguments[0]);
+        const value = context.sourceCode.getText(node.arguments[0]);
         context.report({
           node,
           messageId: 'error',

tools/eslint-rules/set-proto-to-null-in-object.js

@@ -46,7 +46,7 @@ module.exports = {
             message: 'Every object must have __proto__: null',
             fix: function(fixer) {
               // Generate the fix suggestion to add __proto__: null
-              const sourceCode = context.getSourceCode();
+              const sourceCode = context.sourceCode;
               const firstProperty = properties[0];
               const firstPropertyToken = sourceCode.getFirstToken(firstProperty);