From c1e875849140770e5006a2aedccca7b02922ca7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Wed, 29 Mar 2023 12:02:09 +0000 Subject: [PATCH] quic: do not dereference shared_ptr after move The stored pointer is assumed to be nullptr after std::move. --- src/quic/data.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/quic/data.cc b/src/quic/data.cc index fcc2335db7adb9..e3428141f1ec6b 100644 --- a/src/quic/data.cc +++ b/src/quic/data.cc @@ -38,16 +38,16 @@ Store::Store(std::shared_ptr store, size_t length, size_t offset) : store_(std::move(store)), length_(length), offset_(offset) { - CHECK_LE(offset_, store->ByteLength()); - CHECK_LE(length_, store->ByteLength() - offset_); + CHECK_LE(offset_, store_->ByteLength()); + CHECK_LE(length_, store_->ByteLength() - offset_); } Store::Store(std::unique_ptr store, size_t length, size_t offset) : store_(std::move(store)), length_(length), offset_(offset) { - CHECK_LE(offset_, store->ByteLength()); - CHECK_LE(length_, store->ByteLength() - offset_); + CHECK_LE(offset_, store_->ByteLength()); + CHECK_LE(length_, store_->ByteLength() - offset_); } Store::Store(v8::Local buffer, Option option)