From e6c262ceb3a32d042d3452ed47f5a05c914e6e84 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Sun, 12 Mar 2023 16:28:02 +0530 Subject: [PATCH 1/2] test_runner: accept \x1b as a escape symbol Fixes: https://github.com/nodejs/node/issues/46959 --- lib/internal/test_runner/tap_lexer.js | 2 +- test/parallel/test-runner-tap-lexer.js | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/internal/test_runner/tap_lexer.js b/lib/internal/test_runner/tap_lexer.js index a27e6ab35ea1d1..8af5453b283a38 100644 --- a/lib/internal/test_runner/tap_lexer.js +++ b/lib/internal/test_runner/tap_lexer.js @@ -525,7 +525,7 @@ class TapLexer { } #isEscapeSymbol(char) { - return char === '\\'; + return char === '\\' || char === '\x1b'; } #isYamlStartSymbol(char) { diff --git a/test/parallel/test-runner-tap-lexer.js b/test/parallel/test-runner-tap-lexer.js index afc6eea1d2c08b..21ecc0ae7aef74 100644 --- a/test/parallel/test-runner-tap-lexer.js +++ b/test/parallel/test-runner-tap-lexer.js @@ -480,3 +480,15 @@ ok 1 assert.strictEqual(tokens[index].value, token.value); }); } + +{ + const tokens = TAPLexer('\x1b'); + + [ + { kind: TokenKind.ESCAPE, value: '\x1b' }, + { kind: TokenKind.EOL, value: '' }, + ].forEach((token, index) => { + assert.strictEqual(tokens[index].kind, token.kind); + assert.strictEqual(tokens[index].value, token.value); + }); +} \ No newline at end of file From 52c773d3e48101bb75c68ab824dc961064971cb1 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Sun, 12 Mar 2023 16:28:34 +0530 Subject: [PATCH 2/2] fixup! space --- test/parallel/test-runner-tap-lexer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-runner-tap-lexer.js b/test/parallel/test-runner-tap-lexer.js index 21ecc0ae7aef74..96c27fecdea7d0 100644 --- a/test/parallel/test-runner-tap-lexer.js +++ b/test/parallel/test-runner-tap-lexer.js @@ -491,4 +491,4 @@ ok 1 assert.strictEqual(tokens[index].kind, token.kind); assert.strictEqual(tokens[index].value, token.value); }); -} \ No newline at end of file +}