From 5f4b16fb37939920707622bfb3ef8e8b091bdf35 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Wed, 16 Jun 2021 07:20:43 -0400 Subject: [PATCH] build: don't pass `--mode` argument to V8 test-runner V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 58260979e11458..1cfa4ea7137695 100644 --- a/Makefile +++ b/Makefile @@ -667,12 +667,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8. test-v8-intl: v8 export PATH="$(NO_BIN_OVERRIDE_PATH)" && \ deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \ - --mode=$(BUILDTYPE_LOWER) intl \ + intl \ $(TAP_V8_INTL) test-v8-benchmarks: v8 export PATH="$(NO_BIN_OVERRIDE_PATH)" && \ - deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \ + deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \ benchmarks \ $(TAP_V8_BENCHMARKS)