From 14206c117a7c7d5a28a1e5c6b7ed32527f46a5ed Mon Sep 17 00:00:00 2001 From: Shobhit Chittora Date: Thu, 14 Nov 2019 16:45:24 +0530 Subject: [PATCH 1/4] doc: adds NO_COLOR to assert doc page --- doc/api/assert.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/assert.md b/doc/api/assert.md index 7df70f60c35952..c856a42b125d93 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -114,7 +114,7 @@ assert.deepEqual([[[1, 2, 3]], 4, 5], [[[1, 2, '3']], 4, 5]); // ] ``` -To deactivate the colors, use the `NODE_DISABLE_COLORS` environment variable. +To deactivate the colors, use `NO_COLOR` or `NODE_DISABLE_COLORS` environment variables. This will also deactivate the colors in the REPL. ## Legacy mode From 8498a9079701e2b10be10c81e413849a9cb032c6 Mon Sep 17 00:00:00 2001 From: Shobhit Chittora Date: Thu, 14 Nov 2019 17:44:52 +0530 Subject: [PATCH 2/4] doc: fix max line length lint + review comment --- doc/api/assert.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/assert.md b/doc/api/assert.md index c856a42b125d93..31d23ed0617144 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -114,7 +114,8 @@ assert.deepEqual([[[1, 2, 3]], 4, 5], [[[1, 2, '3']], 4, 5]); // ] ``` -To deactivate the colors, use `NO_COLOR` or `NODE_DISABLE_COLORS` environment variables. +To deactivate the colors, use the `NO_COLOR` or +`NODE_DISABLE_COLORS` environment variable. This will also deactivate the colors in the REPL. ## Legacy mode From d788e703bc0c83ad9ca1f5b9b060f3b888da20bb Mon Sep 17 00:00:00 2001 From: Shobhit Chittora Date: Fri, 15 Nov 2019 15:52:04 +0530 Subject: [PATCH 3/4] doc: adds reference to tty color support --- doc/api/assert.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/api/assert.md b/doc/api/assert.md index 31d23ed0617144..c10e2dbcb21b5f 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -118,6 +118,9 @@ To deactivate the colors, use the `NO_COLOR` or `NODE_DISABLE_COLORS` environment variable. This will also deactivate the colors in the REPL. +For more on the color support in terminal environments, read +the tty [getColorDepth](tty.html#tty_writestream_getcolordepth_env) doc. + ## Legacy mode Legacy mode uses the [Abstract Equality Comparison][] in: From 2aed44ffa5a5d8f7173a31cbbc7568728a89729c Mon Sep 17 00:00:00 2001 From: Shobhit Chittora Date: Sat, 16 Nov 2019 21:08:07 +0530 Subject: [PATCH 4/4] doc: adds parenthesis too function call Co-Authored-By: Vse Mozhet Byt --- doc/api/assert.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/assert.md b/doc/api/assert.md index c10e2dbcb21b5f..d27094fec53425 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -119,7 +119,7 @@ To deactivate the colors, use the `NO_COLOR` or This will also deactivate the colors in the REPL. For more on the color support in terminal environments, read -the tty [getColorDepth](tty.html#tty_writestream_getcolordepth_env) doc. +the tty [getColorDepth()](tty.html#tty_writestream_getcolordepth_env) doc. ## Legacy mode