From c9145a4adc48ade8205561076848e7b818fcce5d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 15 Nov 2018 16:47:44 -0800 Subject: [PATCH 1/2] doc: simplify first-time contributors section of Collaborator Guide --- COLLABORATOR_GUIDE.md | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index deadf87ed15092..1b9bcd510c1e13 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). ### Welcoming First-Time Contributors -Courtesy should always be shown to individuals submitting issues and pull -requests to the Node.js project. Be welcoming to first-time contributors, -identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png) -badge. - -For first-time contributors, check if the commit author is the same as the -pull request author, and ask if they have configured their git -[username][git-username] and [email][git-email] to their liking. -This is to make sure they would be promoted to "contributor" once their -pull request lands. +Show courtesy to individuals submitting issues and pull requests. Be welcoming +to first-time contributors, identified by the GitHub +![First-time contributor](./doc/first_timer_badge.png) badge. + +For first-time contributors, check if the commit author is the same as the pull +request author. This way, once their pull request lands, GitHub will show them +as a _Contributor_. Ask if they have configured their git +[username][git-username] and [email][git-email] to their liking. ### Closing Issues and Pull Requests From 3f6045c96e985a5c66bb6a90d44632072e52861f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 16 Nov 2018 11:44:22 -0800 Subject: [PATCH 2/2] fixup! doc: simplify first-time contributors section of Collaborator Guide --- COLLABORATOR_GUIDE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 1b9bcd510c1e13..7c4928a300ab3d 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -50,8 +50,8 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). ### Welcoming First-Time Contributors -Show courtesy to individuals submitting issues and pull requests. Be welcoming -to first-time contributors, identified by the GitHub +Always show courtesy to individuals submitting issues and pull requests. Be +welcoming to first-time contributors, identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png) badge. For first-time contributors, check if the commit author is the same as the pull