diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 63e76a27fab182..f85c224898db30 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,6 +14,3 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) - -##### Affected core subsystem(s) - diff --git a/doc/api/addons.md b/doc/api/addons.md index 03feb8ec619ed5..d2f312b06e72fb 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -34,8 +34,9 @@ involving knowledge of several components and APIs : - Node.js includes a number of other statically linked libraries including OpenSSL. These other libraries are located in the `deps/` directory in the - Node.js source tree. Only the V8 and OpenSSL symbols are purposefully - re-exported by Node.js and may be used to various extents by Addons. + Node.js source tree. Only the libuv, OpenSSL, V8 and zlib symbols are + purposefully re-exported by Node.js and may be used to various extents by + Addons. See [Linking to Node.js' own dependencies][] for additional information. All of the following examples are available for [download][] and may diff --git a/doc/api/assert.md b/doc/api/assert.md index a859408a8be99e..3478adbfaf2e28 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -191,6 +191,11 @@ changes: Asserts that the function `block` does not throw an error. See [`assert.throws()`][] for more details. +Please note: Using `assert.doesNotThrow()` is actually not useful because there +is no benefit by catching an error and then rethrowing it. Instead, consider +adding a comment next to the specific code path that should not throw and keep +error messages as expressive as possible. + When `assert.doesNotThrow()` is called, it will immediately call the `block` function. diff --git a/doc/api/fs.md b/doc/api/fs.md index 3fbdfc34726fe6..a50640477dcfa1 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2238,8 +2238,19 @@ changes: * `callback` {Function} * `err` {Error} -Asynchronous rename(2). No arguments other than a possible exception are given -to the completion callback. +Asynchronously rename file at `oldPath` to the pathname provided +as `newPath`. In the case that `newPath` already exists, it will +be overwritten. No arguments other than a possible exception are +given to the completion callback. + +See also: rename(2). + +```js +fs.rename('oldFile.txt', 'newFile.txt', (err) => { + if (err) throw err; + console.log('Rename complete!'); +}); +``` ## fs.renameSync(oldPath, newPath) +* {number} + +The port used by Node.js's debugger when enabled. +```js +process.debugPort = 5858; +``` ## process.disconnect()