From da300ff3950c335ca906bd7a0f96cd41614ebe82 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 25 Apr 2018 18:10:38 +0200 Subject: [PATCH] build: do not depend on `cp` in `PATH` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use gyp’s own copying mechanism instead. It’s not really clear which UNIX utils exactly are needed to build on Windows, but this is an easier fix (at least for me) than figuring out how to get `cp` into the `PATH` in all cases, and judging from the issue I’m not the only one who ran into this. Fixes: https://github.com/nodejs/node/issues/20272 --- node.gyp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/node.gyp b/node.gyp index abed8ad4c48c10..ac3c28037e8613 100644 --- a/node.gyp +++ b/node.gyp @@ -680,13 +680,13 @@ 'toolsets': ['host'], 'conditions': [ [ 'v8_enable_inspector==1', { - 'actions': [ + 'copies': [ { - 'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder', - 'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ], - 'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ], - 'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ], - }, + 'destination': '<(SHARED_INTERMEDIATE_DIR)', + 'files': ['deps/v8/src/inspector/js_protocol.pdl'] + } + ], + 'actions': [ { 'action_name': 'v8_inspector_convert_protocol_to_json', 'inputs': [