From 6eacabc96a05dd2a741fc84a3ca82290e638c4f4 Mon Sep 17 00:00:00 2001 From: Matthew Cantelon Date: Fri, 6 Oct 2017 17:26:16 +0000 Subject: [PATCH 1/4] first-pr: make test match other tests --- test/addons-napi/test_dataview/test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/addons-napi/test_dataview/test.js b/test/addons-napi/test_dataview/test.js index 87cf8159ab8635..023969af5c8e71 100644 --- a/test/addons-napi/test_dataview/test.js +++ b/test/addons-napi/test_dataview/test.js @@ -10,5 +10,4 @@ const buffer = new ArrayBuffer(128); const template = Reflect.construct(DataView, [buffer]); const theDataview = test_dataview.CreateDataView(template); -assert.ok(theDataview instanceof DataView, - 'The new variable should be of type Dataview'); +assert.ok(theDataview instanceof DataView); From 831344460dbcc0dad2748c9bb17cfec9d5b92c6c Mon Sep 17 00:00:00 2001 From: Matthew Cantelon Date: Tue, 24 Oct 2017 21:58:18 -0700 Subject: [PATCH 2/4] Updated to clearer message --- test/addons-napi/test_dataview/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons-napi/test_dataview/test.js b/test/addons-napi/test_dataview/test.js index 023969af5c8e71..6367bc206d8610 100644 --- a/test/addons-napi/test_dataview/test.js +++ b/test/addons-napi/test_dataview/test.js @@ -10,4 +10,4 @@ const buffer = new ArrayBuffer(128); const template = Reflect.construct(DataView, [buffer]); const theDataview = test_dataview.CreateDataView(template); -assert.ok(theDataview instanceof DataView); +assert.ok(`Expect ${theDataview} to be a DataView`); From 00c8b9b2b64b67286f628a95ddec73a922cd7a00 Mon Sep 17 00:00:00 2001 From: Matthew Cantelon Date: Wed, 25 Oct 2017 06:10:57 -0700 Subject: [PATCH 3/4] Actually test something --- test/addons-napi/test_dataview/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons-napi/test_dataview/test.js b/test/addons-napi/test_dataview/test.js index 6367bc206d8610..7f65a173170078 100644 --- a/test/addons-napi/test_dataview/test.js +++ b/test/addons-napi/test_dataview/test.js @@ -10,4 +10,4 @@ const buffer = new ArrayBuffer(128); const template = Reflect.construct(DataView, [buffer]); const theDataview = test_dataview.CreateDataView(template); -assert.ok(`Expect ${theDataview} to be a DataView`); +assert.ok(theDataview instanceof DataView, `Expect ${theDataview} to be a DataView`); From a01a962943e8e7dd54a6ecb83a1eb62e2c87395e Mon Sep 17 00:00:00 2001 From: Matthew Cantelon Date: Fri, 27 Oct 2017 08:17:57 -0700 Subject: [PATCH 4/4] Fix linting error in test --- test/addons-napi/test_dataview/test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/addons-napi/test_dataview/test.js b/test/addons-napi/test_dataview/test.js index 7f65a173170078..711ab01ddb3cb6 100644 --- a/test/addons-napi/test_dataview/test.js +++ b/test/addons-napi/test_dataview/test.js @@ -10,4 +10,5 @@ const buffer = new ArrayBuffer(128); const template = Reflect.construct(DataView, [buffer]); const theDataview = test_dataview.CreateDataView(template); -assert.ok(theDataview instanceof DataView, `Expect ${theDataview} to be a DataView`); +assert.ok(theDataview instanceof DataView, + `Expect ${theDataview} to be a DataView`);