-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbortController exception in the wrong place and cannot be caught #55742
Comments
Can you provide a minimal reproduction? |
@redyetidev I think this is fixed by nodejs/undici#3354 which iiuc is part of unidici 7.0.0 Any idea how I can get this fix in my docker image today? (I don't care which node I'm running) |
You can manually use undici? Or build Node.js manually with the upgraded version. |
Actually I see this still hasn't been fixed. There is an active discussion about fix/WAI/bug that I haven't been able to fully figure out. |
Could you leave a repro on this issue then? |
@geeksilva97 I don't have a repro, it happens in production under unknown conditions, but others have experienced the same issue, and the same fix works for everyone. You can see the discussion in the pr I linked above. |
Version
23.1.0
What steps will reproduce the bug?
the code in question is https://github.com/webtorrent/bittorrent-tracker/blob/master/lib/client/http-tracker.js#L147
I'm getting the DOMException from the line where the AbortController is created, that is outside the try/catch
How often does it reproduce? Is there a required condition?
Haven't been able to reproduce it locally, happens on a google cloud run instance
What is the expected behavior? Why is that the expected behavior?
The exception should be caught by the try/catch
What do you see instead?
The exception is thrown from an unexpected location.
The text was updated successfully, but these errors were encountered: