Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Zone Bug ('Antarctica/DumontDUrville') #28455

Closed
Lonniebiz opened this issue Jun 27, 2019 · 8 comments
Closed

Time Zone Bug ('Antarctica/DumontDUrville') #28455

Lonniebiz opened this issue Jun 27, 2019 · 8 comments
Labels
confirmed-bug Issues with confirmed bugs. i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.

Comments

@Lonniebiz
Copy link

Lonniebiz commented Jun 27, 2019

There is a timezone bug in Node 10.16.0. It is the same bug that I reported to Chromium here:
https://bugs.chromium.org/p/chromium/issues/detail?id=928068

Run the code in comment 1, from there, to reproduce the bug in Node 10.16.0.

I'm not sure if this is a V8 thing or if each environment has to fix the bug. If it is a V8 thing, perhaps this bug will go away by itself eventually. Otherwise, it needs to be addressed in Node.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 27, 2019

This is a V8 thing that got fixed in Node 12.5.0 via the V8 update.

@bnoordhuis bnoordhuis added question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency. confirmed-bug Issues with confirmed bugs. i18n-api Issues and PRs related to the i18n implementation. and removed question Issues that look for answers. labels Jun 28, 2019
@bnoordhuis
Copy link
Member

Antarctica/DumontDurville was fixed in commit v8/v8@2cf79d12e8 and could be back-ported to the v10.x branch.

Asia/Qostanay requires an ICU update because that's where we get the tzdata from.

@srl295
Copy link
Member

srl295 commented Sep 10, 2019

@Lonniebiz as to Asia/Qostanay — you can check the tz version with node -p process.versions.tz, Asia/Qostanay was added in 2018i which is there by default in ICU ≥64.1 ICU-20331

I just checked Node 10.16.3 and it has ICU 64.2 and tz 2019a. I think we should close this as already fixed in v10.16.0 by b323658 / #27361

@srl295 srl295 closed this as completed Sep 10, 2019
@srl295 srl295 reopened this Sep 10, 2019
@srl295
Copy link
Member

srl295 commented Sep 10, 2019

Whoops. the original issue is still there in v10.x. Reopening.

new Date().toLocaleString("en-US", {timeZone: "Antarctica/DumontDUrville"});

@srl295 srl295 added the v10.x label Sep 10, 2019
@Lonniebiz
Copy link
Author

This bug just adds proof that the earth is flat. This is a fictitious timezone anyway, so don't bother fixing this.

@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

does this need to remain open?

@jasnell
Copy link
Member

jasnell commented Apr 26, 2021

Given that this is limited to 10.x and there will not be another 10.x release before it hits end of life in a few days, going ahead and closing this.

@jasnell jasnell closed this as completed Apr 26, 2021
@srl295
Copy link
Member

srl295 commented Apr 26, 2021

Sorry I didn't get back to this, but closing is the right path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

5 participants