Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: failure on Windows where I run .\vcbuild #25133

Closed
yewenjunfighting opened this issue Dec 19, 2018 · 10 comments
Closed

Build: failure on Windows where I run .\vcbuild #25133

yewenjunfighting opened this issue Dec 19, 2018 · 10 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@yewenjunfighting
Copy link
Contributor

  • Version: v8.11.4
  • Platform: 64-bit (Windows)

I follow the instructions in GUILDING.md
but, when i run .\vcbuild test, The following error has occurred
I mentioned it in node/help yesterday
but you know that there are very few responses
so I have to mention the issue here
If this is not appropriate, you can turn this off

c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1468): error C2065: “keyword”: 未声明的标识符 [C:\Users\172
89\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1474): error C2044: 非法 continue [C:\Users\17289\Desk
top\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1477): error C2065: “keyword”: 未声明的标识符 [C:\Users\172
89\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2059: 语法错误:“if” [C:\Users\17289\Deskto
p\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2143: 语法错误: 缺少“;”(在“{”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2447: “{”: 缺少函数标题(是否是老式的形式表?) [C:\User
s\17289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1487): error C2059: 语法错误:“return” [C:\Users\17289\De
sktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1490): error C2059: 语法错误:“}” [C:\Users\17289\Desktop
\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1490): error C2143: 语法错误: 缺少“;”(在“}”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1491): error C2143: 语法错误: 缺少“;”(在“}”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1491): error C2059: 语法错误:“}” [C:\Users\17289\Desktop
\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
@bzoz
Copy link
Contributor

bzoz commented Dec 19, 2018

Could you please provide the entire output of vcbuild?

@ZYSzys
Copy link
Member

ZYSzys commented Dec 19, 2018

It looks a bit like #7734 (comment).

@yewenjunfighting
Copy link
Contributor Author

ok wait a minute

@yewenjunfighting
Copy link
Contributor Author 

C:\Users\17289\Desktop\pr\node>.\vcbuild test
Looking for Python 2.x
Looking for NASM
Looking for Visual Studio 2017
calling: "C:\BuildTools\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2017 Developer Command Prompt v15.0
** Copyright (c) 2017 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 15.0
Reusing solution generated with  --with-pch --dest-cpu=x64
  v8_libbase.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\v8_libbase.lib
  openssl.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\openssl.lib
  torque_base.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\torque_base.lib
  openssl-cli.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\openssl-cli.exe
  icuucx.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\icuucx.lib
  icui18n.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\icui18n.lib
  icustubdata.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\icustubdata.lib
  icutools.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\icutools.lib
  bytecode_builtins_list_generator.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\bytecode_builtins_list_generator.
  exe
  icupkg.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\icupkg.exe
  genccode.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\genccode.exe
  genrb.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\genrb.exe
  iculslocs.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\iculslocs.exe
  torque.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\\torque.exe
  icudata.vcxproj -> C:\Users\17289\Desktop\pr\node\Release\lib\icudata.lib
  intl-objects.cc
c:\users\17289\desktop\pr\node\deps\icu-small\source\common\unicode\stringoptions.h : warning C4819: 该文件包含不能在当前代码页(936)
中表示的字符。请将该文件保存为 Unicode 格式以防止数据丢失 [C:\Users\17289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(785): warning C4819: 该文件包含不能在当前代码页(936)中表示的字符。请将该文件保
存为 Unicode 格式以防止数据丢失 [C:\Users\17289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1468): error C2065: “keyword”: 未声明的标识符 [C:\Users\172
89\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1474): error C2044: 非法 continue [C:\Users\17289\Desk
top\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1477): error C2065: “keyword”: 未声明的标识符 [C:\Users\172
89\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2059: 语法错误:“if” [C:\Users\17289\Deskto
p\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2143: 语法错误: 缺少“;”(在“{”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1480): error C2447: “{”: 缺少函数标题(是否是老式的形式表?) [C:\User
s\17289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1487): error C2059: 语法错误:“return” [C:\Users\17289\De
sktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1490): error C2059: 语法错误:“}” [C:\Users\17289\Desktop
\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1490): error C2143: 语法错误: 缺少“;”(在“}”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1491): error C2143: 语法错误: 缺少“;”(在“}”的前面) [C:\Users\1
7289\Desktop\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
c:\users\17289\desktop\pr\node\deps\v8\src\objects\intl-objects.cc(1491): error C2059: 语法错误:“}” [C:\Users\17289\Desktop
\pr\node\deps\v8\gypfiles\v8_base.vcxproj]
Building Node with reused solution failed. To regenerate project files use "vcbuild projgen"

@yewenjunfighting
Copy link
Contributor Author

when i run .\vcbuild projgen
it's the same error

@sagitsofan
Copy link
Contributor

Did you try to update Visual Studio 2017 Developer Command Prompt using Visual studio installer?

@yewenjunfighting
Copy link
Contributor Author

maybe not

@ChALkeR ChALkeR added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Dec 19, 2018
@3ea2c2b 3ea2c2b mentioned this issue Feb 2, 2019
Closed
@yanite
Copy link

yanite commented Mar 8, 2019

what code ??? // This is fine.™ pls delete ™

@hamkoo
Copy link

hamkoo commented Jun 27, 2019

Open "node\deps\v8\src\objects\intl-objects.cc" with notepad and save as with Encoding=Unicode

@pd4d10
Copy link
Contributor

pd4d10 commented Nov 6, 2019 •
edited
Loading

Set deps\v8\src\objects\intl-objects.cc file's encoding to UTF-16 LE. It works for me

Probably related to #25885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ChALkeR @hamkoo @sagitsofan @yanite @pd4d10 @bzoz @ZYSzys @yewenjunfighting